Update conda package publish for muliple python versions #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
karlhigley
reviewed
Apr 27, 2023
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.8] |
There was a problem hiding this comment.
Wondering if we could add 3.9 and 3.10 here so the builds run in separate actions?
There was a problem hiding this comment.
I read some possibly old docs that you could pass in multiple values for the python parameter, which seems like it doesn't work. Updated to the matrix version again and checking if this works now
oliverholworthy
commented
May 4, 2023
| echo "conda_package=$CONDA_PACKAGE" >> $GITHUB_OUTPUT | ||
| conda install -c conda-forge mamba | ||
| mamba install -c conda-forge conda-build boa conda-verify pybind11 | ||
| conda mambabuild --python ${{ matrix.python-version }} . -c defaults -c conda-forge -c numba -c rapidsai -c nvidia --output-folder ./conda_packages |
There was a problem hiding this comment.
Using mambabuild instead of regular conda build cut the build time down from 3-5 hours to about 10 minutes.
|
This PR has already been applied to the release branch, and sucessfully published versions of the conda package for Python 3.9 and 3.10 (in addition to 3.8). Still needs to be merged into main so that this will also apply to the next release |
karlhigley
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates conda package build so that we build and publish the NVTabular conda package for multiple python versions.
Currently we only publish a package for Python 3.8. This PR adds a package for 3.9, 3.10, in addition to 3.8.
And removes the upper bound on the cupy version in the dependencies